Sync pass/fail and scores #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a reasonable way to solve the problem, better than my idea of changing xapi-db-load itself to send more correct pass/fail events based on course grade updates, but have you checked performance? I think this may be a fair bit slower that the way it's being calculated now. |
|
Good call, I'll run some performance tests and update with the findings |
|
Ran on clickhouse with a dataset of 4M rows - current query used 601 MiB and this new query used 611 MiB so definitely not a large increase |
bmtcril
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openedx/xapi-db-load#117
'earned' events include score and a grade classification that we are currently not using. This change uses that (for course events) in combination with the pass/fail events
caveat: passed/failed verb events do NOT have a score associated with them so there is still a possibility of a learner with 'passed' status and '0' score
new dashboard data:
'earned' grade classification data:
